Re: [PATCH linux-next] mm/hugetlb: fix warning inalloc_huge_page/dequeue_huge_page_vma

From: Mel Gorman
Date: Tue Apr 17 2012 - 10:05:51 EST


On Tue, Apr 17, 2012 at 04:28:19PM +0400, Konstantin Khlebnikov wrote:
> This patch fixes gcc warning (and bug?) introduced in linux-next commit cc9a6c877
> ("cpuset: mm: reduce large amounts of memory barrier related damage v3")
>
> Local variable "page" can be uninitialized if nodemask from vma policy does not
> intersects with nodemask from cpuset. Even if it wouldn't happens it's better to
> initialize this variable explicitly than to introduce kernel oops on weird corner case.
>
> mm/hugetlb.c: In function ???alloc_huge_page???:
> mm/hugetlb.c:1135:5: warning: ???page??? may be used uninitialized in this function
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
> Cc: Mel Gorman <mgorman@xxxxxxx>

Acked-by: Mel Gorman <mgorman@xxxxxxx>

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/