On 4/17/2012 9:50 AM, Laxman Dewangan wrote:Using regmap for accessing register through i2c bus. This willI'd prefer the intial tab fixup for the kconfig file as a separate
remove the code for caching registers, read-modify-write logics.
Also it will provide the debugfs feature to dump register
through regmap debugfs.
patch, but other than that
all looks good.
This will probably cause issues alongside the series I sent to Greg the
other day though
so you may want to sit on it for a day or two and rebase.
Signed-off-by: Laxman Dewangan<ldewangan@xxxxxxxxxx>Acked-by: Jonathan Cameron<jic23@xxxxxxxxxx>---Down to here is a valid but unconnected change. Can you break this out
drivers/staging/iio/light/Kconfig | 19 ++--
drivers/staging/iio/light/isl29018.c | 176 +++++++++++++++++-----------------
2 files changed, 99 insertions(+), 96 deletions(-)
diff --git a/drivers/staging/iio/light/Kconfig b/drivers/staging/iio/light/Kconfig
index 53b49f7..fd39f72 100644
--- a/drivers/staging/iio/light/Kconfig
+++ b/drivers/staging/iio/light/Kconfig
@@ -4,15 +4,16 @@
menu "Light sensors"
config SENSORS_ISL29018
- tristate "ISL 29018 light and proximity sensor"
- depends on I2C
- default n
- help
- If you say yes here you get support for ambient light sensing and
- proximity infrared sensing from Intersil ISL29018.
- This driver will provide the measurements of ambient light intensity
- in lux, proximity infrared sensing and normal infrared sensing.
- Data from sensor is accessible via sysfs.
+ tristate "ISL 29018 light and proximity sensor"
+ depends on I2C
+ select REGMAP_I2C
+ default n
+ help
+ If you say yes here you get support for ambient light sensing and
+ proximity infrared sensing from Intersil ISL29018.
+ This driver will provide the measurements of ambient light intensity
+ in lux, proximity infrared sensing and normal infrared sensing.
+ Data from sensor is accessible via sysfs.
to a separate patch?