RE: [PATCH] rtc: tegra: cleanup probe/remove routines

[Venu Byravarasu]

Should be fine.

> -----Original Message-----
> From: Hannu Heikkinen [mailto:hannuxx@xxxxxx]
> Sent: Friday, April 13, 2012 6:24 PM
> To: Venu Byravarasu
> Cc: rtc-linux@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> a.zummo@xxxxxxxxxxxx
> Subject: Re: [PATCH] rtc: tegra: cleanup probe/remove routines
> 
> On 13/04/12 11:05 +0530, Venu Byravarasu wrote:
> > > +	if (info->tegra_rtc_irq <= 0)
> > > +		return -EBUSY;
> > Interrupt support is needed only for wake up or timer support.
> > Apart from them RTC can be used for reference time keeping.
> >
> > So, is it not good to print a warn message as "wake up
> > with alarm is not supported" and proceed further instead of
> > returning failure from the driver itself?
> 
> I propose that this patch would go in as is, as this is mainly for adjusting
> probe/remove routines for using devm_* funcs, and to leave that above issue
> you mentioned to another patch, as it would be a change to current behavior.
> 
> 
> br,
> Hannu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/