Re: [PATCH 04/12] atl1c: remove VPD register

[David Miller]

From: xiong <xiong@xxxxxxxxxxxxxxxx>
Date: Sat, 14 Apr 2012 17:59:20 +0800

> VPD register is only used for L1(devid=PCI_DEVICE_ID_ATTANSIC_L1) to
> access external NV-memory.
> l1c & later chip doesn't use it any more.
> no special userspace tool interpret the dumpped registers.
> dumpping them via ethtool is just for debug.
> 
> Signed-off-by: xiong <xiong@xxxxxxxxxxxxxxxx>
> Tested-by: Liu David <dwliu@xxxxxxxxxxxxxxxx>

I'm really disappointed that you're posting this patch again and
completely ignoring our feedback.

You're making this code buggy, and you're make me extremely irritated.

What's the point of our feedback if you just completely ignore it?

You can't crap up the register dump like this, you have to make
several modifications if you want to change the layout in any
way:

1) You have to adjust AT_REGS_LEN, because you're reporting one
   less register.

2) You have to adjust the offsets at the end of atl1c_get_regs(),
   the ones that explicitly use regs_buff[73] and regs_buf[74],
   otherwise you're leaving a gap between that area that's filled
   in using those p++ pointer increments and the entries filled
   in with these explicit offsets into reg_buff[].

3) You have to increment the register dump version, via the struct
   ethtool_regs 'version' field, so that userland programs can know
   that you've changed it.

So, tell me, are you going to completely ignore our feedback on
this issue again?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/