Re: [tip:perf/core] perf ui annotate browser: Allow toggling addroffset view

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> > Now, fancy arrows etc might be too hard to do (especially 
> > without cluttering things up too much), but marking just the 
> > targets would already be lovely. IOW, turn this mess:
> > 
> > 
> >          :        ffffffff810d7e80 <kmem_cache_free>:
> >     1.91 :        ffffffff810d7e80:       push   %rbp
> >     0.05 :        ffffffff810d7e81:       mov    %rsp,%rbp
> >     2.02 :        ffffffff810d7e84:       push   %r12
> >     0.00 :        ffffffff810d7e86:       mov    %rdi,%r12
> >     0.55 :        ffffffff810d7e89:       push   %rbx
> >     0.00 :        ffffffff810d7e8a:       mov    %rsi,%rdi
> >     1.20 :        ffffffff810d7e8d:       mov    %rsi,%rbx
> >     1.64 :        ffffffff810d7e90:       callq  ffffffff8102a730 <__phys_addr>
> >     0.05 :        ffffffff810d7e95:       movabs $0xffffea0000000000,%rdi
> >     0.22 :        ffffffff810d7e9f:       shr    $0xc,%rax
> >     0.11 :        ffffffff810d7ea3:       shl    $0x6,%rax
> >     1.64 :        ffffffff810d7ea7:       lea    (%rax,%rdi,1),%rdi
> >    42.80 :        ffffffff810d7eab:       mov    (%rdi),%rax
> >     2.02 :        ffffffff810d7eae:       test   $0x80,%ah
> >     0.00 :        ffffffff810d7eb1:       jne    ffffffff810d7ef6
> > <kmem_cache_free+0x76>
> >     0.22 :        ffffffff810d7eb3:       mov    0x8(%rbp),%r9
> >     7.14 :        ffffffff810d7eb7:       mov    (%r12),%rax
> >     0.65 :        ffffffff810d7ebb:       add    %gs:0xcb88,%rax
> >     4.58 :        ffffffff810d7ec4:       mov    0x8(%rax),%rdx
> > 
> > (which has tons of unnecessary white-space too - shades of G+) into
> 
> Grin ;-)
> 
> Yeah, even the : column isn't needed I think.

Such delineators are sometimes useful visually, it emulates a 
vertical line and makes it easier for the brain to ignore the 
left or right side. We'll fine-tune it.

The occasional color highlighting is useful too, as long as it 
is used sparingly.

> > Sure, leave some magic keycombination to get the "full 
> > information", but ..
> 
> Yeah, we have o to toggle offset view + s to toggle source 
> code view, etc.

I suspect the default view should be the 'most intelligent' mode 
of assembly output we can offer - with easy toggles for the rare 
cases where someone would like to do something special, plus 
.perfconfig overrides for those with weird workflows and those 
with a taste different from ours.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/