Re: sky2: in free_buffers() do proper checks before call ofrx_clean()

From: David Miller
Date: Fri Apr 13 2012 - 13:00:06 EST


From: Lino Sanfilippo <LinoSanfilippo@xxxxxx>
Date: Tue, 3 Apr 2012 02:13:27 +0200

> In sky2_open() free_buffers() is called in case that alloc_buffers() failed.
> Here we do the check for sky2->rx_le too late, since we already called
> rx_clean() which accessed rx_le. Furthermore we lack a check for sky2->rx_ring
> which is also accessed by rx_clean().
>
> With this patch both sky2->rx_le and sky2->rx_ring are checked before
> alloc_buffers() is called.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>

Stephen, I'm still waiting on your review of this patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/