Re: [RFC] workqueue: do a sanity check on new work

[Tejun Heo]

Hello, Dan.

On Fri, Apr 13, 2012 at 7:35 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> There may be a better way to do this.  If someone tries to call
> shedule_work() on a work_struck before doing an INIT_WORK() then we
> hit the BUG_ON(!list_empty(&work->entry)) in __queue_work() and hang.
> Instead of that, we could just print a stack dump and return.

Hmmm... why not just change the BUG_ON() in __queue_work() to "if
(WARN_ON()) return;"?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/