Re: [PATCH v2 1/2] mfd: da9052: add device-tree support for i2cdriver

From: Mark Brown
Date: Fri Apr 13 2012 - 10:33:02 EST


On Fri, Apr 13, 2012 at 09:37:40PM +0800, Ying-Chun Liu (PaulLiu) wrote:

> + regulators {
> + buck0 {
> + regulator-name = "DA9052_BUCK_CORE";
> + regulator-min-microvolt = <500000>;
> + regulator-max-microvolt = <2075000>;
> + };

This is more of a nit but these names look like they aren't terribly
idiomatic and could just be omitted - normally the name is used to tie
the name to the supply on the schematic so the above might be "VCORE" or
something. If no name is provided then whatever the driver provides
will be used.

Attachment: signature.asc
Description: Digital signature