Re: [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug

From: Jiang Liu
Date: Fri Apr 13 2012 - 10:24:37 EST


Hi Shuah and Toshi,
As I can tell, _OST method has been defined in ACPI4.0 spec and
there are some platforms already implemented the _OST method. For example,
Quanta QSSC-S4R server implements _OST for hot-pluggable PCI slots, but
it's a little pity that it doesn't implement _OST for the memory board,
so we can't test Toshi's patch on that platform.
According to my understanding, other than notifying BIOS about the
event processing result, _OST could also be used to notify BIOS about the
IN_PROGRESS state, so BIOS could track the event handling progress and avoid
timeout. We have used _OST method to avoid timeout on one of our prototype
platforms.

On 04/12/2012 10:19 PM, Shuah Khan wrote:
>
>> Hi Shuah,
>>
>> The fake _OST methods print arguments to verify successful execution of
>> the methods. Since the purpose of _OST is firmware-internal
>> communication, there is no difference in testing on real firmware from
>> the OS perspective. Overriding DSDT with fake ACPI methods is a
>> well-established and widely used testing method as well.
>
> Toshi,
>
> This patch hasn't gone through sufficient new functionality testing as
> the only testing that was done was exercising it with stubbed out
> firmware calls. I am not clear on how much regression testing this patch
> has undergone. Sorry, it doesn't give me the warm and fuzzies.
>
> -- Shuah
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/