Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filenamefrom sata_dwc_460ex.c to sata_dwc_4xx.c

[Jeff Garzik]

On 04/03/2012 07:56 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 03-04-2012 14:12, Thang Q. Nguyen wrote:
>
> > Signed-off-by: Thang Q. Nguyen<tqnguyen@xxxxxxx>
> > ---
> > Changes for v2:
> > - Use git rename feature to change the driver to the newname and for
> > easier review.
>
> > arch/powerpc/boot/dts/bluestone.dts | 21 +
> > drivers/ata/Makefile | 2 +-
> > drivers/ata/{sata_dwc_460ex.c => sata_dwc_4xx.c} | 1371
> > ++++++++++++++--------
> > 3 files changed, 904 insertions(+), 490 deletions(-)
> > rename drivers/ata/{sata_dwc_460ex.c => sata_dwc_4xx.c} (56%)
>
> You submitted a magapatch doing several things at once (some even
> needlessly) and even in two areas of the kernel. This needs proper
> splitting/description.

Agreed...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/