Re: [RESEND PATCH v2] libata: disable runtime pm for hotpluggableport

[Jeff Garzik]

On 04/12/2012 01:56 AM, Lin Ming wrote:
> Currently, hotplug doesn't work if port is already runtime suspended.
> For now, we simply disable runtime pm for hotpluggable port.
> Later, we should add runtime pm support for hotpluggable port too.
>
> Bug report:
> https://lkml.org/lkml/2012/2/19/70
>
> v2:
> - Use bit 2 and 3 for flags ATA_FLAG_EXTERNAL and ATA_FLAG_PLUGGABLE.
>
> TODO: add similar hotpluggable port check for controllers other than
> AHCI.
>
> Reported-and-tested-by: Jiri Slaby<jslaby@xxxxxxx>
> Reported-and-tested-by: cwillu@xxxxxxxxxx
> Reported-and-tested-by: jackdachef@xxxxxxxxx
> Signed-off-by: Lin Ming<ming.m.lin@xxxxxxxxx>
> ---
>   drivers/ata/ahci.c             |    3 +++
>   drivers/ata/ahci.h             |    3 +++
>   drivers/ata/libahci.c          |   20 ++++++++++++++++++++
>   drivers/ata/libata-transport.c |    6 ++++--
>   include/linux/libata.h         |    2 ++
>   5 files changed, 32 insertions(+), 2 deletions(-)

The fundamental problem with this patch is that all SATA ports are 
hotpluggable... even the ones the firmware/silicon failed to mark as 
hotpluggable via AHCI's PORT_CMD_MPSP | PORT_CMD_HPCP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/