Re: TIF_NOTIFY_RESUME [was Re: [PATCH v2 1/2] task_work_queue: addgeneric process-context callbacks]

From: Oleg Nesterov
Date: Thu Apr 12 2012 - 13:42:14 EST


On 04/12, David Howells wrote:
>
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > +#ifdef TIF_NOTIFY_RESUME
>
> If we're going to keep this feature, I wonder if it's worth just requiring the
> arches lacking this feature to add it at this point, rather than adding all
> this conditional logic.

Yes, agreed. But until we update m68k/xtensa task_work has to check
if it is defined.

I'll try to cleanup this in v3. In fact, task_work_queue() makes sense
even without TIF_NOTIFY_RESUME, just it lacks set_notify_resume().

> It doesn't look like it should be too hard for m68k, but xtensa looks tricky.

I was going to add the maintainers ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/