Re: [PATCH 3/5] drivers/net: remove IS_ENABLED usage from wiznetdrivers

From: Paul Gortmaker
Date: Thu Apr 12 2012 - 13:15:52 EST


On 12-04-11 07:54 PM, David Miller wrote:
> From: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> Date: Wed, 11 Apr 2012 19:50:55 -0400
>
>> The use of IS_ENABLED in C code (vs just in CPP #if directives)
>> causes us to carry the burden of a huge autoconf.h file. It is
>> also misleading in that a casual inspection of the code would
>> leave one thinking that the if statements were evaluated at
>> runtime, when TX_FLOW is a Kconfig bool and hence evaluated
>> at configure time as an either/or.
>>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
>
> Want me to toss this into net-next?

Yes, that makes sense since wiznet only exists there currently.

Thanks,
Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/