Re: RFC: deprecating/removing the legacy mode of devpts

From: Kay Sievers
Date: Wed Apr 11 2012 - 22:49:14 EST


On Thu, Apr 12, 2012 at 04:45, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Apr 12, 2012 at 04:27:55AM +0200, Kay Sievers wrote:
>> On Thu, Apr 12, 2012 at 03:08, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>> > On Sun, Apr 08, 2012 at 09:16:22PM +0200, Kay Sievers wrote:
>> >
>> >> I guess the following:
>> >> ?? - remove the 'ptmx' cdev from drivers/tty/pty.c
>> >> ?? - add a new devtmpfs_create_link() to drivers/base/devtmpfs.c
>> >> ?? - call devtmpfs_create_link() from _init in fs/devpts/inode.c
>> >> ?? - change the default of ptxmode=0 to a sane default = 0666
>> >> ?? - get rid of the (rather broken) idea of 'legacy' vs 'non-legacy mode'
>> >> ?? ?? mount options in the default setup; I don't think userspace should
>> >> ?? ?? ever be required to fiddle with such stuff
>> >
>> > You do realize that there are people with _static_ /dev out there, don't
>> > you? ??As well as those of us who are not using your latest and greatest
>> > udev and not enabling devtmpfs at all. ??Not all world is Fedora...
>>
>> Yeah, and? The dev_t still works from the static /dev/ like it didi 10
>> years ago. All good.
>
> Only if you move that cdev to fs/devpts/inode.c instead of removing it,
> at which point you get the interesting problems back on other setups...

fs/devpts/inode.c uses the very _same_ registered cdev, nobody wants
or can remove it.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/