Re: [PATCH v3] Input: Elan HID-I2C device driver

[Ping Cheng]

On Wed, Apr 11, 2012 at 9:25 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Wednesday, April 11, 2012 06:09:03 PM ??? wrote:
>> Hi Daniel
>>
>> On 04/11/2012 03:12 PM, Dmitry Torokhov wrote:
>> > Hi Tom,
>> >
>> > On Tue, Apr 10, 2012 at 08:42:46PM +0800, Tom Lin wrote:
>> >> This patch adds driver for Elan I2C touchpad. These protocol of HID-I2C
>> >> was
>> >> defined by Microsoft. The kernel driver would use the multi-touch
>> >> protocol
>> >> format B.
>> >
>> > If this device truly supports HID protocol shouldn't we define i2c-hid
>> > transport, similar to usbhid?
>>
>> I merely follow defined by Microsoft.
>> It was called "HID OVER I2C" by Microsoft.
>> (http://msdn.microsoft.com/en-us/library/windows/hardware/hh825917(v=vs.85).
>> aspx) But I agree to change from hid i2c to i2chid.
>> Do you have any better opinions?
>
> I am not sure we are talking about same thing... I do not really care
> whether it is named "hid i2c" or "i2chid". What I meant if the device
> really speaks HID protocol, except that the transport is not USB or
> bluetooth but I2C, then instead of writing a custom driver for this
> particular part we need to add a new HID transport into
> drivers/hid/i2c-hid that is similar to drivers/hid/usbhid/

I fully agree with Dmitry's suggestion. The new i2chid driver would
cover all hid-compliant i2c devices.

Ping

> and reuse the rest of HID framework along with hid- multitouch.c which handles
> HID-compliant multitouch devices.
>
> I am CCing Jiri (HID maintainer) for additional input.
>
> Thanks.
>
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/