Re: [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug

From: Shuah Khan
Date: Wed Apr 11 2012 - 12:33:15 EST


On Tue, 2012-04-10 at 16:21 -0600, Toshi Kani wrote:
> This series of patches supports ACPI _OST (OSPM Status Indication)
> method for ACPI-based CPU and memory hotplug operations. After
> ACPI-based hotplug operation completed, OSPM calls _OST to convey
> the completion status to ACPI firmware. If _OST is not present,
> this change has no effect on the platform.
>
> The _OST definition can be found in section 6.3.5 of ACPI 5.0 spec.
> The HPPF spec below also describes hotplug flows with _OST.
>
> DIG64 Hot-Plug & Partitioning Flow (HPPF) Specification R1.0
> http://www.dig64.org/home/DIG64_HPPF_R1_0.pdf
>
> The change was tested by overriding DSDT with fake _OST methods.

Could you please elaborate what it means by fake _OST method? I am
assuming based on the above that this patch set was never tested on real
hardware that has support for _OST method? Is that correct? If so why
not wait until you have the opportunity to test it on real hardware
before sending the patch?

-- Shuah
>
> ---
> Toshi Kani (4):
> ACPI: Set hotplug _OST support bit to _OSC
> ACPI: Add acpi_evaluate_ost() for calling _OST
> ACPI: Add _OST support for ACPI CPU hotplug
> ACPI: Add _OST support for ACPI memory hotplug
>
> drivers/acpi/acpi_memhotplug.c | 43 +++++++++++++++++++++++++++++----------
> drivers/acpi/bus.c | 5 ++++
> drivers/acpi/processor_driver.c | 28 ++++++++++++++++++-------
> drivers/acpi/utils.c | 34 ++++++++++++++++++++++++++++++
> include/acpi/acpi_bus.h | 3 ++
> include/linux/acpi.h | 26 ++++++++++++++++++++++-
> 6 files changed, 119 insertions(+), 20 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/