Re: [PATCH 06/16] sched: SCHED_DEADLINE push and pull logic

[Juri Lelli]

On 04/11/2012 06:07 PM, Steven Rostedt wrote:
> On Fri, 2012-04-06 at 09:14 +0200, Juri Lelli wrote:
>
> > +static void check_preempt_equal_dl(struct rq *rq, struct task_struct *p)
> > +{
> > +	/*
> > +	 * Current can't be migrated, useles to reschedule,
>
>   s/useles/useless/
>
> I feel so useles by only adding typo fixes ;-)

Don't know why.. but this instead sounds good to me :-P.

> > +	 * let's hope p can move out.
> > +	 */
> > +	if (rq->curr->dl.nr_cpus_allowed == 1 ||
> > +	    latest_cpu_find(rq->rd->span, rq->curr, NULL) == -1)
> > +		return;
> > +
> > +	/*
> > +	 * p is migratable, so let's not schedule it and
> > +	 * see if it is pushed or pulled somewhere else.
> > +	 */
> > +	if (p->dl.nr_cpus_allowed != 1&&
> > +	    latest_cpu_find(rq->rd->span, p, NULL) != -1)
> > +		return;
> > +
> > +	resched_task(rq->curr);
> > +}
> > +
> > +#endif /* CONFIG_SMP */
> > +

Thanks,

- Juri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/