Re: [PATCH] iqrdomain: Improve formatting in debugfs.
From: Grant Likely
Date: Wed Apr 11 2012 - 10:52:22 EST
On Wed, Apr 11, 2012 at 3:16 AM, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
> Grant Likely <grant.likely@xxxxxxxxxxxx> writes:
>
>> @@ -667,7 +667,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
>> seq_printf(m, "%-15s ", p);
>>
>> data = irq_desc_get_chip_data(desc);
>> - seq_printf(m, "0x%16p ", data);
>> + seq_printf(m, data ? "0x%p " : " %p ", data);
>
> You should be able to use %#p instead to let it add the prefix.
That mostly works, but it doesn't round up the field size to account
for the 2 characters in '0x'. Looks like the %p code needs to be
tweaked to fix that.
Also, gcc complains about it:
/home/grant/hacking/linux/kernel/irq/irqdomain.c: In function ‘virq_debug_show’:
/home/grant/hacking/linux/kernel/irq/irqdomain.c:670:4: warning: '#'
flag used with ‘%p’ gnu_printf format [-Wformat]
Do you know how to suppress that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/