Re: [PATCH] clockevents: Leave broadcast device shtudown only ifthe current device is always running.

[Thomas Gleixner]

On Wed, 11 Apr 2012, Feng Tang wrote:
> > Problem you encountered is not related to leaving the broadcast device
> > in shutdown mode. Problem is that we didn't track the mode change to
> > oneshot and later during idle entry/exit, when we request the broadcast
> > device services using CLOCK_EVT_NOTIFY_BROADCAST_ENTER etc,
> > tick_broadcast_oneshot_control() returns with out doing much as it
> > thinks broadcast device is in periodic mode.
> 
> Just curious, IIUC, the tick_broadcast_switch_to_oneshot() is only called
> during CPU init process in boot time or bring a offlined cpu back on. Why
> is it related to the deep idle?

Because a deep idle state might require the broadcast device and w/o
Suresh's patch it can't use it because it's in the wrong state.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/