re: regulator: core: Use a struct to pass in regulator runtimeconfiguration

From: Dan Carpenter
Date: Wed Apr 11 2012 - 05:07:02 EST


Hello Mark Brown,

This is a semi-automatic email about new static checker warnings.

The patch c172708d38a4: "regulator: core: Use a struct to pass in
regulator runtime configuration" from Apr 4, 2012, leads to the
following Smatch complaint:

drivers/regulator/core.c:2860 regulator_register()
warn: variable dereferenced before check 'config' (see line 2856)

drivers/regulator/core.c
2855 struct regulator_dev *rdev;
2856 struct device *dev = config->dev;
^^^^^^^^^^^
New dereference.

2857 int ret, i;
2858 const char *supply = NULL;
2859
2860 if (regulator_desc == NULL || config == NULL)
^^^^^^^^^^^^^^
New check.

2861 return ERR_PTR(-EINVAL);
2862

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/