Re: [PATCH 2/2] dma/amba-pl08x: add support for the Nomadik variant

[Viresh Kumar]

On 4/11/2012 1:29 PM, Linus Walleij wrote:
>>> >> +                             ch->locked = true;
>>> >> +                     } else
>>> >> +                             ch->locked = false;
>>> >> +             }
>>> >> +
>> >
>> > Memory for ch is allocated with kmalloc and so its default value is garbage.
>> > So we must set locked to false in else part here.
> Hm maybe better to kzalloc() the channel structs?
> 

Then, you can remove code which makes its field zero explicitly, as it is already
zero.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/