Re: [PATCH RESEND] ASoC: Fix setting aif_val in lm49453_set_dai_fmt
From: MR Swami Reddy
Date: Tue Apr 10 2012 - 10:07:17 EST
This issues was fixed last week itself.
URL for the patch -
http://mailman.alsa-project.org/pipermail/alsa-devel/2012-April/050967.html
Thanks
Swami
On Monday 09 April 2012 05:18 PM, Axel Lin wrote:
> CBS/CBM/CFS/CFM settings are controlled by BIT[3:4] of 0x60h
>
> for example, for SND_SOC_DAIFMT_CBS_CFS: what we want is to clear both BIT[3:4].
>
> aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS | ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> actually set both bits.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> Seems the my mail failed to reach alsa mailing list.
> I resend to LKML instead.
>
> Axel
> sound/soc/codecs/lm49453.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
> index 744063d..a25e80a 100644
> --- a/sound/soc/codecs/lm49453.c
> +++ b/sound/soc/codecs/lm49453.c
> @@ -1185,16 +1185,12 @@ static int lm49453_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
>
> switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> case SND_SOC_DAIFMT_CBS_CFS:
> - aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> break;
> case SND_SOC_DAIFMT_CBS_CFM:
> - aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> + aif_val = LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> break;
> case SND_SOC_DAIFMT_CBM_CFS:
> - aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> - ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
> + aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS;
> break;
> case SND_SOC_DAIFMT_CBM_CFM:
> aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
> --
> 1.7.5.4
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/