Re: [PATCH] init: fix bug where environment vars can't be passedvia boot args

[Pawel Moll]

On Fri, 2012-04-06 at 17:53 +0100, Chris Metcalf wrote:
> Commit 026cee0086f had the side-effect of dropping the '=' from
> the unknown boot arguments that are passed to init as environment
> variables.  This is because parse_args() puts a NUL in the string
> where the '=' was when it passes the "param" and "val" pointers
> to the parsing subfunctions.  Previously, unknown_bootoption() was
> the last parse_args() subfunction to run, and it carefully put back
> the '=' character.  Now ignore_unknown_bootoption() is the last
> one to run, and it wasn't doing the necessary repair, so the
> envp params ended up with the embedded NUL and were no longer
> seen as valid environment variables by init.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>

Looks sensible to me.

Acked-by: Pawel Moll <pawel.moll@xxxxxxx>

Thanks and apologies about delayed answer (and for causing the problem
in the first place :-)

PaweÅ


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/