[PATCH] Removed less than zero check, since Schedule_timeout return value is guaranteed to be non-negative

From: Sasikantha babu
Date: Tue Apr 10 2012 - 05:01:18 EST


validating timeout against negiatve value is not required, schedule_timeout always returns >= 0.

If someone passes timeout as negative value, Instead of simply returning -ETIME we have to warn them (schedule_timeout
is already doing it by dumping stack and priniting an error message) about it.

We must return -ETIME on timer expiry not for invaild timeouts.

Signed-off-by: Sasikantha babu <sasikanth.v19@xxxxxxxxx>
---
kernel/semaphore.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/semaphore.c b/kernel/semaphore.c
index 60636a4..029c05b 100644
--- a/kernel/semaphore.c
+++ b/kernel/semaphore.c
@@ -214,7 +214,7 @@ static inline int __sched __down_common(struct semaphore *sem, long state,
for (;;) {
if (signal_pending_state(state, task))
goto interrupted;
- if (timeout <= 0)
+ if (!timeout)
goto timed_out;
__set_task_state(task, state);
raw_spin_unlock_irq(&sem->lock);
--
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/