Re: [PATCH] pch_uart: Fix dma channel unallocated issue

From: Tomoya MORINAGA
Date: Mon Apr 09 2012 - 21:26:24 EST


On Tue, Apr 10, 2012 at 2:44 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> This driver anticipates pch_uart_verify_port() is not called
>> during installation.
>> However, actually pch_uart_verify_port() is called during
>> installation.
>> As a result, memory access violation occurs like below.
>>
>> 0. initial value: use_dma=0
>> 1. starup()
>>     - dma channel is not allocated because use_dma=0
>> 2. pch_uart_verify_port()
>>     - Set use_dma=1
>> 3. UART processing acts DMA mode because use_dma=1
>>      - memory access violation occurs!
>>
>> This patch fixes the issue.
>>
>> Solution:
>> Whenever pch_uart_verify_port() is called and then
>> dma channel is not allocated, the channel should be allocated.
>>
>> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@xxxxxxxxx>
>> ---
>>  drivers/tty/serial/pch_uart.c |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> This patch does not apply to 3.4-rc2, so I can not apply it, sorry.
>
> Care to redo it?

This patch depends on the following patch you've already accepted.