Re: [PATCH][REGRESSION] panic: fix stack dump print on direct callto panic()

From: Andi Kleen
Date: Mon Apr 09 2012 - 15:36:22 EST


> That is an interesting patch series, but I am not sure I agree about the caller propagating a flag to control what you see in panic. I intentionally set CONFIG_DEBUG_VERBOSE=y for a reason, I want a stack trace if and when panic(), oops, BUG, etc... is ever called. This might be a personal preference, but I do not wish to be searching on a string, to find out where the kernel execution terminated. I want to see stack traces all the time, with the exception of the cases you pointed out in the original patch.

The idea was that callers who are calling panic not due to a programming
error (like no root, hardware error etc.) do not print the backtrace.
And only "assert like" panics would.

This makes the screen less cluttered for user or hardware induced
panics.

Besides that it does a couple of related things, like set proper
timeouts.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/