Re: [PATCH 1/2] 8250_pci: Replace commits 448ac154 and e86ff4a

From: Williams, Dan J
Date: Mon Apr 09 2012 - 13:59:06 EST


On Mon, Apr 9, 2012 at 10:48 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Apr 09, 2012 at 09:53:47AM -0700, Williams, Dan J wrote:
>> On Mon, Apr 9, 2012 at 9:47 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> > On Tue, Apr 03, 2012 at 09:58:32PM +0100, Alan Cox wrote:
>> >> On Tue, 3 Apr 2012 12:43:20 -0700
>> >> sudhakar <sudhakar@xxxxxx> wrote:
>> >>
>> >> >
>> >> > From: Sudhakar Mamillapalli <sudhakar@xxxxxx>
>> >> >
>> >> >
>> >> > The following commits don't completely fix the KT serial missing
>> >> > interrupt problems.  So they have been replaced instead by
>> >> > enabling serial backup timer.  The iir-once + msi tried approach tried
>> >> > to enforce one read of the iir per THRE event, but its defeated by any
>> >> > other event occurring at the wrong time, particularly MSR events.
>> >> >
>> >> > 448ac15 serial/8250_pci: setup-quirk workaround for the kt serial controller
>> >> > e86ff4a serial/8250_pci: init-quirk msi support for kt serial controller
>> >>
>> >> These are already in tree. If you are reversing them and adding a
>> >> different fix then please post the series as
>> >>
>> >> - two revert patches exactly reverting the two commits
>> >> - a follow on patch or two adding the replacement
>> >>
>> >> That makes it much easier to review and much more obvious. It also helps
>> >> make testing simpler.
>> >
>> > I agree, Sudhakar, can you please redo these 2 patches?
>> >
>>
>> Hi Greg,
>>
>> This was in the series:
>>
>> [PATCH 0/6] rework quirks for the "kt" serial port [1]
>>
>> ...but I have just noticed it collides with current git, and I also
>> need to address Stephen's comments for Tegra.  Expect a v2 shortly.
>
> Ok, thanks.  Note, I just applied the first 3 to go to Linus soon, those
> didn't need to be reworked, right?
>

Correct, those were ready to go. Thanks!

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/