Re: [PATCH] irq/irq_domain: Quit ignoring error returns from irq_alloc_desc_from().

From: David Daney
Date: Mon Apr 09 2012 - 12:52:29 EST


On 04/06/2012 04:56 PM, Grant Likely wrote:
On Fri, 06 Apr 2012 09:37:49 -0700, David Daney<ddaney.cavm@xxxxxxxxx> wrote:
On 04/05/2012 08:37 PM, Rob Herring wrote:
On 04/05/2012 06:52 PM, David Daney wrote:
From: David Daney<david.daney@xxxxxxxxxx>
@@ -380,14 +381,14 @@ unsigned int irq_create_mapping(struct irq_domain *domain,
hint = hwirq % irq_virq_count;
if (hint == 0)
hint++;
- virq = irq_alloc_desc_from(hint, 0);

You are not looking at mainline. hint was removed in later versions, and
the referenced commit ids don't exist.

Please look at Linus' tree before making incorrect statements about
whether or not code exists on the 'mainline'

Rob is indeed mistaken here, but please let's keep things civil.

Sorry about that. You are correct that it is not acceptable.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/