Re: [PATCH] net: orphan queued skbs if device tx can stall

From: Herbert Xu
Date: Mon Apr 09 2012 - 04:40:08 EST


On Mon, Apr 09, 2012 at 11:34:02AM +0300, Michael S. Tsirkin wrote:
>
> Puzzled. This patch orphans skbs only if the destination device sets
> IFF_TX_CAN_STALL. Since the physical NIC doesn't stall forever it never
> sets this flag.
>
> So it seems that this patch should not affect the configuration
> you describe at all.
>
> Could you please clarify? What did I miss?

Oops, you're right. Somehow I was thinking you were patching
virtio-net instead of tun.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/