Re: [RFC 4/5] hid: Add idtags to modalias

From: Henrik Rydberg
Date: Tue Apr 03 2012 - 06:56:02 EST


> > +       /* Generic MT device */
> > +       { .driver_data = MT_CLS_DEFAULT,
> > +               HID_USB_MT_DEVICE(HID_ANY_ID,
> > +                       HID_ANY_ID) },
>
> This breaks the mechanism used to detect serial protocol.
> A better solution would be to keep .driver_data = 0 -> this would tell
> us that the device is unknown and that we can override the given
> settings.

Good point, will do.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/