Re: [PATCH] usb: musb: make modules behave better

[ABRAHAM, KISHON VIJAY]

Hi,

On Mon, Apr 2, 2012 at 8:04 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote:
> Hi Felipe,
>
> On Thu, Jan 26, 2012 at 12:45:49PM +0200, Felipe Balbi wrote:
>> There's really no point in doing all that
>> initcall trickery when we can safely let
>> udev handle module probing for us.
>>
>> Remove all of that trickery, by moving everybody
>> to module_init() and making proper use of
>> platform_device_register() rather than
>> platform_device_probe().
>>
>> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
>> ---
>>
>> Because this falls into the "has never worked before" category
>> I will be sending this only on the next merge window. This
>> also gives people enough time to complain about any mistakes
>> on the patch.
>
> This patch looks correct and right to me, but it breaks musb when it's
> compiled into the kernel, at least on the Nokia N950. I haven't yet figured
> out exactly why, though.

Is it an abort?
You can use the patch which I've sent to the list last week for fixing it.
http://www.spinics.net/lists/linux-usb/msg60603.html.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/