Re: [PATCH v5 2/2] Ethernet driver for the WIZnet W5100 chip

From: Francois Romieu
Date: Sat Mar 31 2012 - 05:49:03 EST


Francois Romieu <romieu@xxxxxxxxxxxxx> :
[...]
> The start_tx logic seems broken anyway: it claims it always can take
> packets until it is given one it can't process. The driver should rather
> do the opposite and stop queueing as soon as there is no guarantee for
> the next packet.

Forget it: the driver stops queuing in this path anyway.

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/