Re: [GIT PULL] Disintegrate and kill asm/system.h

[Grant Likely]

On Fri, 30 Mar 2012 16:48:52 +0900, Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
> On Thu, Mar 29, 2012 at 03:14:29PM +1100, Benjamin Herrenschmidt wrote:
> > > We are currently getting:
> > > kernel/irq/irqdomain.c: In function 'irq_debugfs_init':
> > > kernel/irq/irqdomain.c:698:63: error: 'powerpc_debugfs_root' undeclared (first use in this function)
> > > kernel/irq/irqdomain.c:698:63: note: each undeclared identifier is reported only once for each function it appears in
> > > 
> > >   ae3a197 Disintegrate asm/system.h for PowerPC
> > > is conflicting with 
> > >   cc79ca6 irq_domain: Move irq_domain code from powerpc to kernel/irq
> > > from Grant's tree.
> > > 
> > > Adding the following patch fixes it for pseries_defconfig, although I'm
> > > not sure it's the right fix.
> > 
> > That will do as a quick fix (Linus, can you take it now ?), however..
> > 
> > > Grant: why does powerpc_debugfs_root appear in generic code?  This seems
> > > very bogus.
> > 
> > Yes, Grant, you should move that to a different (generic) debugfs file,
> > the mapping information is valuable debug data for all architectures
> > that use the remapper, not just powerpc and it's not an ABI (no tool I
> > know of rely on the location of that debugfs file) so feel free to move
> > it around.
> > 
> There is a arch_debugfs_dir defined by linux/debugfs.h, but at the moment
> it's only provided by x86 and sh.

Since this data can be used by any arch now, it doesn't make much
sense to put it in arch_debugfs_dir.  I've put it in
/debug/irq_domain_mapping which should be fine.

g.


-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/