Re: [PATCH 9/9] perf tools: Remove auto-generated bison/flex files

[David Daney]

On 03/30/2012 09:43 AM, Namhyung Kim wrote:
> Hi,
>
> Arnaldo Carvalho de Melo<acme@xxxxxxxxxxxxx>  wrote:
> > From: Ingo Molnar<mingo@xxxxxxxxxx>
> >
> > These should not be in the Git history - they are auto-generated.
> >
> > Extend the Makefile rules of the parser files to include the generation
> > run.
> >
> > Signed-off-by: Ingo Molnar<mingo@xxxxxxx>
[...]
> > +FLEX = $(CROSS_COMPILE)flex
> > +BISON= $(CROSS_COMPILE)bison
>
> Just out of curiousity, is this $(CROSS_COMPILE) prefix really needed
> for flex/bison?

I think not.  Actually, I think it is actively incorrect.

I have done quite a bit of cross building of things requiring either 
bison or flex, and have never encountered  $(CROSS_COMPILE)bison, so I 
would think that it is unlikely that many people have one.  On the other 
hand the native tools work fine.

David Daney



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/