Re: [PATCH 02/13] edac: move dimm properties to struct memset_info

From: Borislav Petkov
Date: Fri Mar 30 2012 - 09:10:46 EST


Please don't call it 'memset_info' - this is misleading beyond belief.

Hmm, what struct memset_info - where the hell is this? It is nowhere to
be seen in the patches following that one too, WTF?

On Thu, Mar 29, 2012 at 01:45:35PM -0300, Mauro Carvalho Chehab wrote:
> On systems based on chip select rows, all channels need to use memories
> with the same properties, otherwise the memories on channels A and B
> won't be recognized.
>
> However, such assumption is not true for all types of memory
> controllers.
>
> Controllers for FB-DIMM's don't have such requirements.
>
> Also, modern Intel controllers seem to be capable of handling such
> differences.
>
> So, we need to get rid of storing the DIMM information into a per-csrow
> data, storing it, instead at the right place.
>
> The first step is to move grain, mtype, dtype and edac_mode to the
> per-dimm struct.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/