Re: [PATCH 57/76] ACPI / Video: blacklist some samsung laptops

[Corentin Chary]

On Fri, Mar 30, 2012 at 12:14 PM, Len Brown <lenb@xxxxxxxxxx> wrote:
> From: Corentin Chary <corentincj@xxxxxxxxxx>
>
> On these laptops, the ACPI video is not functional, and very unlikely
> to be fixed by the vendor. Note that intel_backlight works for some
> of these laptops, and the backlight from samsung-laptop always work.
>
> The good news is that newer laptops have functional ACPI video device
> and won't end up growing this list.
>
> Signed-off-by: Corentin Chary <corentincj@xxxxxxxxxx>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> ---
> Âdrivers/acpi/video_detect.c | Â 49 +++++++++++++++++++++++++++++++++++++++++++
> Â1 file changed, 49 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index f3f0fe7..b6f6979 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -132,6 +132,53 @@ find_video(acpi_handle handle, u32 lvl, void *context, void **rv)
> Â Â Â Âreturn AE_OK;
> Â}
>
> +/* Force to use vendor driver when the ACPI device is known to be
> + * buggy */
> +static int video_detect_force_vendor(const struct dmi_system_id *d)
> +{
> + Â Â Â acpi_video_support |= ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
> + Â Â Â return 0;
> +}
> +
> +static struct dmi_system_id video_detect_dmi_table[] = {
> + Â Â Â {
> + Â Â Â Â.callback = video_detect_force_vendor,
> + Â Â Â Â.ident = "N150P",
> + Â Â Â Â.matches = {
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_PRODUCT_NAME, "N150P"),
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_BOARD_NAME, "N150P"),
> + Â Â Â Â Â Â Â },
> + Â Â Â },
> + Â Â Â {
> + Â Â Â Â.callback = video_detect_force_vendor,
> + Â Â Â Â.ident = "N145P/N250P/N260P",
> + Â Â Â Â.matches = {
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_PRODUCT_NAME, "N145P/N250P/N260P"),
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_BOARD_NAME, "N145P/N250P/N260P"),
> + Â Â Â Â Â Â Â },
> + Â Â Â },
> + Â Â Â {
> + Â Â Â Â.callback = video_detect_force_vendor,
> + Â Â Â Â.ident = "N150/N210/N220",
> + Â Â Â Â.matches = {
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_PRODUCT_NAME, "N150/N210/N220"),
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_BOARD_NAME, "N150/N210/N220"),
> + Â Â Â Â Â Â Â },
> + Â Â Â },
> + Â Â Â {
> + Â Â Â Â.callback = video_detect_force_vendor,
> + Â Â Â Â.ident = "NF110/NF210/NF310",
> + Â Â Â Â.matches = {
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_PRODUCT_NAME, "NF110/NF210/NF310"),
> + Â Â Â Â Â Â Â DMI_MATCH(DMI_BOARD_NAME, "NF110/NF210/NF310"),
> + Â Â Â Â Â Â Â },
> + Â Â Â },
> +};
> +
> Â/*
> Â* Returns the video capabilities of a specific ACPI graphics device
> Â*
> @@ -164,6 +211,8 @@ long acpi_video_get_capabilities(acpi_handle graphics_handle)
> Â Â Â Â Â Â Â Â * Â Â Â Â Â Â ÂACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
> Â Â Â Â Â Â Â Â *}
> Â Â Â Â Â Â Â Â */
> +
> + Â Â Â Â Â Â Â dmi_check_system(video_detect_dmi_table);
> Â Â Â Â} else {
> Â Â Â Â Â Â Â Âstatus = acpi_bus_get_device(graphics_handle, &tmp_dev);
> Â Â Â Â Â Â Â Âif (ACPI_FAILURE(status)) {
> --
> 1.7.10.rc2.19.gfae9d
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html

Hi Len,

Sorry for that but this patch was re-sent recently, and Matthew told
me to do that this should be done in samsung-laptop.c instead.

The resulting patch has been merged in Matthew's tree:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=blobdiff;f=drivers/platform/x86/samsung-laptop.c;h=e2a34b42ddc1d584b5333fe9921d0d2c2b12dda4;hp=4787afdf11dc20e69af8fe5324366d4bd65aeb98;hb=a979e2e2af7d5b4bb3b20f6a716c627bb23a6753;hpb=5719b81988f3c24ff694dc3a37e35b35630a3966

One of these patches should be reverted, but which one ?
Note that apple-gmux and acer-wmi are also using the
acpi_video_unregister() trick in linux-next.

Thanks,

-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/