Re: [PATCH/RFC] dmaengine: add a slave parameter to__dma_request_channel()

From: Russell King - ARM Linux
Date: Fri Mar 30 2012 - 06:29:27 EST


On Fri, Mar 16, 2012 at 03:28:39PM +0100, Guennadi Liakhovetski wrote:
> Yessss!!! Let's do that! :-D Now, you're proposing exactly the same, as
> what I was proposing! :-) Now you just have to remove the filter function
> parameter from dma_request_channel() - it is anyway the same for all and
> implemented in the dmaengine core - and you get
>
> dma_request_channel(mask, slave_desc)
>
> which is exactly what I was proposing! :-)

Bollocks it is. You're wanting to use the peripheral address, width
and burst size to try to determine what channel to use. That's a
totally crackpot idea, and as I've already said several times it won't
work in many real life cases we have already.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/