Re: [PATCH v4] Ethernet driver for the WIZnet W5300 chip

From: David Miller
Date: Tue Mar 27 2012 - 22:36:03 EST


From: Mike Sinkovsky <msink@xxxxxxxxxxxxx>
Date: Mon, 26 Mar 2012 15:07:56 +0600

> +/*
> + * Frame size is hardwired to 1514 bytes (including header),
> + * => MTU for 802.1Q frames must be set to 1500-4 = 1496
> + */
> +#define W5300_HARD_MTU 1500

I've told you that you must set the VLAN challenged feature flag
(NETIF_F_VLAN_CHALLENGED) for devices which have this restriction.

Just set that, and remove this comment, since the feature bit setting
documents this restriction fully and perfectly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/