Re: [PATCH v5]: Hibernation: lower/better control the amount of pages used for buffering

From: Rafael J. Wysocki
Date: Tue Mar 27 2012 - 19:14:37 EST


On Wednesday, March 28, 2012, Bojan Smojver wrote:
> On Wed, 2012-03-28 at 00:54 +0200, Rafael J. Wysocki wrote:
> > That's better, but what's wrong with a static inline, actually?
>
> Nothing, if that is what is required to get the patch accepted. :-)
>
> I just thought that given that nr_free_pages() is already a macro with
> no side effects, it would make sense for reqd_free_pages() or
> REQD_FREE_PAGES to remain a macro.
>
> But, if you insist on static inline, I'll do static inline. Let me know.

Please do. You can even convert nr_free_pages() to a static inline while
you're at it. :-)

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/