Re: [tip:perf/urgent] perf/x86: Add SNB offcore event constraints

[Stephane Eranian]

On Tue, Mar 27, 2012 at 8:36 AM, tip-bot for Peter Zijlstra
<a.p.zijlstra@xxxxxxxxx> wrote:
> Commit-ID: Âc370117c978adba861fad467427a9301c2c7082b
> Gitweb: Â Â http://git.kernel.org/tip/c370117c978adba861fad467427a9301c2c7082b
> Author: Â Â Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> AuthorDate: Thu, 22 Mar 2012 11:41:23 +0100
> Committer: ÂIngo Molnar <mingo@xxxxxxxxxx>
> CommitDate: Tue, 27 Mar 2012 14:53:46 +0200
>
> perf/x86: Add SNB offcore event constraints
>
> As found in the Intel SDM (March 2012 edition) in Volume 3
> section 18.8.5, the offcore response events are constrained
> to PMC0 and PMC3 resp..
>
I don't believe this is correct in the SDM. It may be a side effect
of how Intel tools work. I'll check again.

> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Stephane Eranian <eranian@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxx>
> Link: http://lkml.kernel.org/n/tip-n6vf6grjv94vnzvuccu0clcv@xxxxxxxxxxxxxx
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> ---
> Âarch/x86/kernel/cpu/perf_event_intel.c | Â 14 ++++++++------
> Â1 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
> index 26b3e2f..bab8c6d 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel.c
> @@ -96,12 +96,14 @@ static struct event_constraint intel_westmere_event_constraints[] __read_mostly
>
> Âstatic struct event_constraint intel_snb_event_constraints[] __read_mostly =
> Â{
> - Â Â Â FIXED_EVENT_CONSTRAINT(0x00c0, 0), /* INST_RETIRED.ANY */
> - Â Â Â FIXED_EVENT_CONSTRAINT(0x003c, 1), /* CPU_CLK_UNHALTED.CORE */
> - Â Â Â FIXED_EVENT_CONSTRAINT(0x0300, 2), /* CPU_CLK_UNHALTED.REF */
> - Â Â Â INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
> - Â Â Â INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
> - Â Â Â INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
> + Â Â Â FIXED_EVENT_CONSTRAINT(0x00c0, 0), Â Â Â/* INST_RETIRED.ANY */
> + Â Â Â FIXED_EVENT_CONSTRAINT(0x003c, 1), Â Â Â/* CPU_CLK_UNHALTED.CORE */
> + Â Â Â FIXED_EVENT_CONSTRAINT(0x0300, 2), Â Â Â/* CPU_CLK_UNHALTED.REF */
> + Â Â Â INTEL_EVENT_CONSTRAINT(0x48, 0x4), Â Â Â/* L1D_PEND_MISS.PENDING */
> + Â Â Â INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), Â /* INST_RETIRED.PREC_DIST */
> + Â Â Â INTEL_EVENT_CONSTRAINT(0xcd, 0x8), Â Â Â/* MEM_TRANS_RETIRED.LOAD_LATENCY */
> + Â Â Â INTEL_UEVENT_CONSTRAINT(0x01b7, 0x1), Â /* OFFCORE_RSP_0 */
> + Â Â Â INTEL_UEVENT_CONSTRAINT(0x01bb, 0x8), Â /* OFFCORE_RSP_1 */
> Â Â Â ÂEVENT_CONSTRAINT_END
> Â};
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/