Re: [PATCH v4] x86, olpc: add debugfs interface for EC commands

[Andres Salomon]

On Mon, 26 Mar 2012 15:53:59 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 26 Mar 2012 16:45:10 -0600
> Daniel Drake <dsd@xxxxxxxxxx> wrote:
> 
> > On Mon, Mar 26, 2012 at 3:29 PM, Andrew Morton
> > <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > s/fix/break/? __"Originally-from" is not a recognised tag. __If
> > > this code is based upon an earlier version from Paul then
> > > Signed-off-by: is correct.
> > >
> > > What's going on here? __What are you trying to communicate?
> > 
> > I'm trying to take Ingo's suggestion, in the thread "[patch 1/8]
> > x86, olpc: add debugfs interface for EC commands" he wrote:
> > 
> > ====
> > This is not a valid signoff sequence - the 'From: ' author of
> > the patch must be the first SOB line.
> > 
> > The way to do this is either to have a:
> > 
> >  From: Paul Fox <pgf@xxxxxxxxxx>
> > 
> > or to covert Paul Fox's SOB to a credit line, such as:
> > 
> >  Originally-from: Paul Fox <pgf@xxxxxxxxxx>
> > ====
> > 
> > The original code was from Paul Fox. I changed it somewhat
> > significantly, and Paul approves of the end result.
> > Can someone suggest a way of expressing this, including tag
> > ordering, that will be accepted by all parties?  :)
> 
> From: Daniel Drake <dsd@xxxxxxxxxx>
> 
> ....
> 
> The original code was from Paul Fox.  I changed it somewhat
> significantly, and Paul approves of the end result.
> 
> Signed-off-by: Paul Fox <pgf@xxxxxxxxxx>
> Signed-off-by: Daniel Drake <dsd@xxxxxxxxxx>


This makes a lot more sense to me (and has been used in the past by
both myself and dsd for OLPC submissions) rather than having a plethora
of machine-parsable tags that no one cares about.  Minus the "approves
of the end result" bit, though, as that's implicit in the SOB line.
There are innumerable possible variants of this (Originally-by,
Co-authored-with, Based-on-code-in-another-project-by,
Written-while-being-whipped-by, and so on).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/