Re: [PATCH RFT v2] watchdog: Convert orion_wdt driver to watchdogcore

From: Andrew Lunn
Date: Mon Mar 26 2012 - 13:36:25 EST


> > static int __devinit orion_wdt_probe(struct platform_device *pdev)
> > @@ -241,26 +146,28 @@ static int __devinit orion_wdt_probe(struct platform_device *pdev)
> > struct resource *res;
> > int ret;
> >
> > - if (pdata) {
> > - wdt_tclk = pdata->tclk;
> > - } else {
> > + if (!pdata) {
> > pr_err("misses platform data\n");
> > return -ENODEV;
> > }
>
> Platform data is changing soon with devicetree support (and converting
> to common clock). Please don't change this if you don't need to.
>
> Also, I'll include Andrew Lunn in the CC. He's doing the conversion of
> orion over to common clock, which affects this driver.

Yep,

Once the merge is over and the first -rc kernel is released, i will
post my patches rebased on that. For wdt, clk is no longer in the
platform data.

Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/