Re: [PATCH 03/25] vfs: split __dentry_open()

[Christoph Hellwig]

On Wed, Mar 07, 2012 at 10:22:20PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@xxxxxxx>
> 
> Split __dentry_open() into two functions:
> 
>   do_dentry_open() - does most of the actual work, doesn't put file on failure
>   open_check_o_direct() - after a successful open, checks direct_IO method
> 
> This will allow i_op->atomic_open to do just the file initialization and leave
> the direct_IO checking to the VFS.

I think the O_DIRECT checks should move out of the VFS.  The direct I/O
method isn't called from the VFS anywhere, but just from the
generic_file_* routines in filemap.c, which suggest doing the O_DIRECT
check in there as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/