Re: [PATCH 0/6] Add a per-dimm structure

From: Borislav Petkov
Date: Thu Mar 15 2012 - 07:31:53 EST


On Wed, Mar 14, 2012 at 10:44:13PM -0300, Mauro Carvalho Chehab wrote:
> As I said, that is easy to implement. The hard part would be what to do with
> the per-csrow/per-branch error counters that exist currently at EDAC.
>
> From my side, I'm OK to remove them, but, as I said before, existing user tools
> use them,

What are you talking about? Those per-rank counters should be the same
as the per-csrow ch0 and ch1 counters...

> especially because UE errors aren't per-rank/per-dimm on the
> typical case (128 bits cacheline).

It depends - if the 128 bit word comes from a single DIMM (unganged
mode) then you have a per-rank UE.

> Of course, the EDAC logic could increment multiple UE error counters
> in such case, (meaning that an error happened on either one of the
> affected DIMMs/Ranks) but this is a different behavior than the
> current API.

Well, the API should be changed to accomodate such configurations.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/