Re: [PATCH v12 2/3] ARM: EXYNOS: Change System MMU platform devicedefinitions

From: Joerg Roedel
Date: Thu Mar 15 2012 - 07:12:40 EST


On Thu, Mar 15, 2012 at 05:32:39PM +0900, Cho KyongHo wrote:
> Handling System MMUs with an identifier is not flexible to manage
> System MMU platform devices because of the following reasons:
> 1. A device driver which needs to handle System MMU must know the ID.
> 2. A System MMU may not present in some implementations of Exynos family.
> 3. Handling System MMU with IOMMU API does not require an ID.
>
> This patch is the result of removing ID of System MMUs.
> Instead, a device driver that needs to handle its System MMU must
> use IOMMU API while its descriptor of platform device is given.
>
> This patch also includes the following enhancements:
> - A System MMU device becomes a child if its power domain device.
> - clkdev
>
> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> Signed-off-by: KyongHo Cho <pullip.cho@xxxxxxxxxxx>
> ---
> arch/arm/mach-exynos/Kconfig | 10 +-
> arch/arm/mach-exynos/Makefile | 2 +-
> arch/arm/mach-exynos/clock-exynos4.c | 79 ++--
> arch/arm/mach-exynos/clock-exynos4.h | 2 +
> arch/arm/mach-exynos/clock-exynos4210.c | 11 +
> arch/arm/mach-exynos/clock-exynos4212.c | 28 ++-
> arch/arm/mach-exynos/clock-exynos5.c | 90 +++++
> arch/arm/mach-exynos/dev-sysmmu.c | 457 ++++++++++++----------
> arch/arm/mach-exynos/include/mach/irqs.h | 25 +-
> arch/arm/mach-exynos/include/mach/map.h | 38 ++
> arch/arm/mach-exynos/include/mach/regs-clock.h | 5 +
> arch/arm/mach-exynos/include/mach/regs-sysmmu.h | 28 --
> arch/arm/mach-exynos/include/mach/sysmmu.h | 88 +++--
> arch/arm/mach-exynos/mach-armlex4210.c | 1 -
> arch/arm/mach-exynos/mach-smdkv310.c | 1 -
> 15 files changed, 529 insertions(+), 336 deletions(-)
> delete mode 100644 arch/arm/mach-exynos/include/mach/regs-sysmmu.h

This patch doesn't apply cleanly against upstream Linux (v3.3-rcX).
Please rebase to upstream and resend. The other 2 patches apply fine.


Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/