Re: [PATCH v3 2/2] DMAEngine: Add DMAEngine driver based on old MSMDMA APIs

From: Lars-Peter Clausen
Date: Wed Mar 14 2012 - 12:24:47 EST


> [...]
> +
> +struct dma_async_tx_descriptor *msm_dma_prep_interleaved(struct dma_chan *dchan,
> + struct dma_interleaved_template *xt,
> + unsigned long flags, void *context)
> +{
> +
> + struct msm_dma_chan *chan;
> + struct msm_dma_desc_sw *new;
> + struct adm_box_cmd_t *box_cmd_vaddr;
> + u32 *cmd_cntrl = context;
> +
> + if (!dchan)
> + return ERR_PTR(-EINVAL);

This is supposed to return either NULL or a valid descriptor.

> +
> + if (!xt)
> + return ERR_PTR(-EINVAL);
> [...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/