Re: [PATCH -V3 3/8] hugetlb: add charge/uncharge calls for HugeTLB alloc/free

From: Aneesh Kumar K.V
Date: Wed Mar 14 2012 - 06:47:41 EST


On Tue, 13 Mar 2012 14:36:54 -0700, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 13 Mar 2012 12:37:07 +0530
> "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> wrote:
>
> > + return ERR_PTR(-VM_FAULT_SIGBUS);
>
> whee, so we have (ab)used the err.h infrastructure to carry
> VM_FAULT_foo codes, thus creating a secret requirement that the
> VM_FAULT_foo values not exceed MAX_ERRNO.
>
> What a hack, whodidthat?

e0dcd8a05be438b3d2e49ef61441ea3a463663f8. We only do that in hugetlb. I
will add a cleanup patch that will return proper error and map them in
the caller to return SIGBUS.

-aneesh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/