Re: [PATCH v2] mmc: sdhci: check interrupt flags in ISR again

From: Adrian Hunter
Date: Wed Mar 14 2012 - 05:24:20 EST


On 14/03/12 10:52, Alexander Stein wrote:
> When using MSI it is possible that a new MSI is sent while an earlier
> MSI is currently handled. In this case SDHCI_INT_STATUS only contains
> SDHCI_INT_RESPONSE and the ISR would not be called again. But at the end
> of the ISR SDHCI_INT_DATA_END is now also pending which would be ignored.
>
> Fix this by rereading the interrupt flags in the ISR until no interrupt
> we care is pending.
>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx>
> ---
> Changes in v2:
> * rearranged code a bit and added a maximum loop counter as suggested
> by Adrian
>
> drivers/mmc/host/sdhci.c | 19 ++++++++++++-------
> 1 files changed, 12 insertions(+), 7 deletions(-)

Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/