Re: [PATCH v3 4/4] powerpc: Board support for GE IMP3A

From: Linus Walleij
Date: Tue Mar 13 2012 - 07:51:54 EST


On Mon, Mar 12, 2012 at 6:13 PM, Martyn Welch <martyn.welch@xxxxxx> wrote:

> Initial board support for the GE IMP3A, a 3U compactPCI card with a p2020
> processor.
(...)
> +++ b/arch/powerpc/configs/ge_imp3a_defconfig
> @@ -0,0 +1,257 @@
> +CONFIG_PPC_85xx=y
> +CONFIG_SMP=y
> +CONFIG_NR_CPUS=2
> +CONFIG_EXPERIMENTAL=y
> +CONFIG_SYSVIPC=y
> +CONFIG_POSIX_MQUEUE=y
> +CONFIG_BSD_PROCESS_ACCT=y
> +CONFIG_BSD_PROCESS_ACCT_V3=y
> +CONFIG_SPARSE_IRQ=y

This habit of changing a lot of defconfig stuff in a patch dealing with other
stuff is alien in the ARM world. Especially when changing a horde of stuff
that has nothing to do with the patch subject.

But I don't really know how PPC does these things so who am I to
speak ...

BTW: doesn't the "make saveconfig" reduce defconfigs on PPC?
Paging Uwe on this.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/