[PATCH 1/1] of: add NULL parameter check for of_device_is_available

From: Dong Aisheng
Date: Tue Mar 13 2012 - 07:37:59 EST


From: Dong Aisheng <dong.aisheng@xxxxxxxxxx>

This function will return 1 even the device node passed in
is NULL which is a little error-prone.
Change to return 0 if the device node passed in is NULL.

Signed-off-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
---
drivers/of/base.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 133908a..b9347d8 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -280,6 +280,9 @@ int of_device_is_available(const struct device_node *device)
const char *status;
int statlen;

+ if (device == NULL)
+ return 0;
+
status = of_get_property(device, "status", &statlen);
if (status == NULL)
return 1;
--
1.7.0.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/